Add clarifications for documentation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
approved these changes
Aug 14, 2023
Comment on lines
+12
to
+16
| This library introduces the marker trait [`ImplicitClone`](https://docs.rs/implicit-clone/latest/implicit_clone/trait.ImplicitClone.html) intended for | ||
| cheap-to-clone types that should be allowed to be cloned implicitly. It enables host libraries | ||
| using this crate to have the syntax of [`Copy`][std::marker::Copy] while actually calling the | ||
| [`Clone`][std::clone::Clone] implementation instead (usually when host library does such syntax | ||
| in a macro). |
There was a problem hiding this comment.
I like very much the new wording 👍 thanks!
| @@ -62,7 +73,7 @@ impl_implicit_clone!( | |||
| f32, f64, | |||
| bool, | |||
| usize, isize, | |||
| &'static str, char, | |||
Co-authored-by: Cecile Tonglet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the text of
lib.rsandtrait ImplicitClonedocumentations, hopefully clarifying some points that caused #6.Also while writing new documentation, I've noticed missing implementation for a
Copytype&T. There was present implementation for&'static str, but it not only does not have to be'static, it does not even have to bestr- it can beT: ?Sized.Added some tests for the
lib.rstypes, as means of more documentation and examples of using the crate.I believe this will be my last PR before 0.4.1 or 0.5.0 (which one should be used? considering
&'static strhas become&T).